This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add Conv3D gradient test and vjp fixes #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Aug 23, 2019
|
@rxwei could you put a build on this again, since we removed the failing test. |
|
can this and the tranposed conv PRs be merged? |
rxwei
suggested changes
Aug 29, 2019
|
I'll change this wrt #499 and get this up in a while. |
|
@rxwei done. |
|
@rxwei could you trigger a build on this again |
rxwei
reviewed
Aug 30, 2019
|
@rxwei this can be merged. |
rxwei
suggested changes
Aug 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I was the one who originally wrote the layer, Sorry for the errors.
Build and test pass locally.