Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Fix in vjpConv2DBackpropFilter #397

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Conversation

Shashi456
Copy link
Contributor

The differentiation is wrt (x, input):

/// TensorFlow builtin conv2d gradient helper for the filter.
@differentiable(wrt: (x, input), vjp: _vjpConv2DBackpropFilter)
@usableFromInline

While the order of the arguments returned in the vjp is input, x.
Another fix is in the input function the shape needed is the input shape and the one being used is filter shape.

@Shashi456
Copy link
Contributor Author

@rxwei, Actually this is the case for depthwise and conv3d as well, Should i reflect the change there as well?

@dan-zheng
Copy link
Member

dan-zheng commented Jul 30, 2019

@rxwei, Actually this is the case for depthwise and conv3d as well, Should i reflect the change there as well?

Yes, could you please change those as well?

Please also add differentiation tests for the updated operators in Tests/TensorFlowTests/TensorAutoDiffTests.swift. 🙂

You can check correctness against Python TF as is done here.

@Shashi456
Copy link
Contributor Author

can this be tested and merged? Conv2d Differentiation test was added in #443, I'll do the same for conv3d and add a differentiation test today in another PR.

@rxwei
Copy link
Contributor

rxwei commented Aug 19, 2019

Please do a git pull so that the test that was added will run as part of CI.

@Shashi456
Copy link
Contributor Author

This can be merged.

@rxwei rxwei merged commit e465331 into tensorflow:master Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants