Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Adding Squared Hinge Loss #187

Merged
merged 3 commits into from
Jun 9, 2019
Merged

Adding Squared Hinge Loss #187

merged 3 commits into from
Jun 9, 2019

Conversation

Shashi456
Copy link
Contributor

Build and test passes locally.
Reference : #127

@Shashi456
Copy link
Contributor Author

@rxwei Is there a clip function? Or should I add it from here? The function I was thinking of adding was clipbyvalue would I have to define a vjp for it, given I will use it in a loss fn?

@rxwei
Copy link
Contributor

rxwei commented Jun 9, 2019

Not yet. Feel free to add one. I'd suggest naming it clipped(min:max:).

@Shashi456
Copy link
Contributor Author

Yeah I'll add that in a while. Also, @rxwei this PR is good to go, The kokoro run was a success, the latest commit is just merging into master.

@rxwei rxwei merged commit 39c3f07 into tensorflow:master Jun 9, 2019
@Shashi456 Shashi456 deleted the loss branch June 9, 2019 14:25
@Shashi456 Shashi456 mentioned this pull request Jun 11, 2019
Merged
dan12411 pushed a commit to dan12411/swift-apis that referenced this pull request Jun 15, 2019
@Shashi456 @dan12411
Adding Squared Hinge Loss (tensorflow#187)
ad40ff8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shashi456 @rxwei @kokoro-team