-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
cc: @eaplatanios @rxwei |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Sorry for the trivial errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very close to me. Could you make one additional quick-fix?
Thank you for all these PR's!
If you pull from master, failures regarding |
@rxwei this can be merged now. |
Refer discussion here.
I need some help here though, I'm sure this needs a vjp as well but what would a vjp for this look like?
Currently getting this error from the build :
FInally, min and max have a default value of -infinity and +infinity, do we have those identifiers in swift?