Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Add softplus and softsign #225

Merged
merged 5 commits into from
Jun 16, 2019
Merged

Add softplus and softsign #225

merged 5 commits into from
Jun 16, 2019

Conversation

Shashi456
Copy link
Contributor

@Shashi456 Shashi456 commented Jun 13, 2019

We need these operators for other loss functions like kullback-leibler divergence and logcosh.

One small doubt, The comments for softplus and softsign both mention gradients as
gradients: The backpropagated gradients to the corresponding softplus operation.

So am i getting the logic right by passing gradients: v?

Tests pass.

@Shashi456
Copy link
Contributor Author

@saeta sorry, I was probably copying them for reference but didn't remove them.

@eaplatanios
Copy link
Contributor

eaplatanios commented Jun 13, 2019

@Shashi456 @saeta softplus is also added in #148.

@Shashi456
Copy link
Contributor Author

@rxwei should I remove softplus from this ? Also #148 takes the derivative as sigmoid, I know it's right. But is there a good reason to not use softplusGrad given within the bindings?

@rxwei rxwei self-assigned this Jun 13, 2019
@Shashi456
Copy link
Contributor Author

@rxwei could you put a build tag on this or are you waiting for #148? In that case I'll remove softplus from here and let this PR go ahead with adding softsign.

@Shashi456
Copy link
Contributor Author

Shashi456 commented Jun 14, 2019

Sorry, made some changes for build errors but did not push them till now. The build and test should pass now

@Shashi456
Copy link
Contributor Author

@rxwei :P, Can you trigger a build once more?

@Shashi456
Copy link
Contributor Author

@rxwei so the build passes, the error is from move, was the toolchain updated for that?

@Shashi456
Copy link
Contributor Author

Requesting a build on this.

@rxwei rxwei changed the title Adding softplus and softsign Add softplus and softsign Jun 16, 2019
@rxwei rxwei merged commit 5c5f557 into tensorflow:master Jun 16, 2019
@rxwei
Copy link
Contributor

rxwei commented Jun 16, 2019

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants