This repository was archived by the owner on Jul 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
suggested changes
Jun 13, 2019
@saeta sorry, I was probably copying them for reference but didn't remove them. |
@Shashi456 @saeta |
Sorry, made some changes for build errors but did not push them till now. The build and test should pass now |
@rxwei :P, Can you trigger a build once more? |
@rxwei so the build passes, the error is from |
Requesting a build on this. |
rxwei
reviewed
Jun 16, 2019
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need these operators for other loss functions like kullback-leibler divergence and logcosh.
One small doubt, The comments for softplus and softsign both mention gradients as
gradients: The backpropagated gradients to the corresponding softplus operation.
So am i getting the logic right by passing
gradients: v
?Tests pass.