This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add logarithm-cosine loss #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
approved these changes
Jun 13, 2019
rxwei
suggested changes
Jun 13, 2019
dan-zheng
reviewed
Jun 13, 2019
rxwei
reviewed
Jun 13, 2019
rxwei
reviewed
Jun 13, 2019
rxwei
reviewed
Jun 13, 2019
|
#225 has been merged. Please pull from master when you get a chance and I'll kick off a build for you. |
|
I'll do it immediately |
rxwei
reviewed
Jun 16, 2019
|
Requesting a final build on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #225.
Otherwise passes locally.
I had a very hacky way of getting the helper logcosh to work. But I could not figure out how to get around the
error: binary operator '-' cannot be applied to operands of type 'Tensor<Scalar>' and '_'that pops up when i dox + softplus(Tensor(-2) * x) - log(2). If you have suggestions please tell me.Reference #127