This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add DepthwiseConv2D #241
Merged
Add DepthwiseConv2D #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing filter shape to depthwiseKernelShape Changing filter shape to depthwiseKernelShape some more build error changes Another build error
rxwei
suggested changes
Jun 14, 2019
rxwei
reviewed
Jun 14, 2019
|
I'll take this up in a while. |
|
@rxwei wdyt? I'll file an issue for convolution documentation consistency. |
rxwei
reviewed
Jun 16, 2019
|
@rxwei build and test pass locally. This is ready. |
rxwei
reviewed
Jun 16, 2019
|
This can be merged now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build passes locally.
cc: @rxwei @dan-zheng - If you both are okay with naming and indentation, I'll go ahead and write the tests.