Remove unnecessary calls to the TensorShape initializer #249
Conversation
rxwei
changed the title
There was a problem hiding this comment.
Thanks for cleaning this up!
As a suggestion for clarity improvement, the PR message "Removing tensorshape from extensions" is an unclear description that may cause a lot of confusion to people who were not in the PR conversation we had in the other thread. This PR is not removing all TensorShapes from extensions, but removing the unnecessary calls to the TensorShape initializer (a.k.a. init(_:)) from certain places where there is a contextual type. In the interest of preventing confusion for other reviewers and contributors, I changed your PR description to "Remove unnecessary calls to the TensorShape initializer". Going forward, if we strive for clear PR descriptions and commit messages, this will help make code reviews be quicker and more effective.
|
@rxwei alright, I'll take care of the same. I'm not extremely good at PR naming, so I always make sure that I link to any sort of discussion the PR is based on. I'll try harder from next time. |
Refer to this discussion.