This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add support for dilated Conv1D and Conv2D #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaplatanios
reviewed
Jun 22, 2019
eaplatanios
reviewed
Jun 22, 2019
|
@eaplatanios Thanks for pointing that out. Wish we had a designated formatter 😄. |
eaplatanios
reviewed
Jun 22, 2019
eaplatanios
approved these changes
Jun 22, 2019
|
@eaplatanios @rxwei Although I see the extensions have dilation as optional, I'm wondering why dilation wasn't made optional in the main public init, because the dilated convolutions aren't used by everyone. Even within the raw bindings, they are an optional parameter with some default value declared. So is the case for the tensorflow and keras convolution APIs. Wdyt? |
|
@Shashi456 good point. I added some defaults along with some minor stylistic changes in #277. |
|
+1 to default arguments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#274
The documentation for some layers seem to be lacking in detail. I'll try to clarify some things when I get the chance.