-
Notifications
You must be signed in to change notification settings - Fork 137
Fix documentation errors in convolutional layers #281
Conversation
Hey @Shashi456 isn't it a bit redundant to summarize the layer by listing its initialization parameters? |
@jon-tow I think so too on some level. But what i've discovered is we have documentation consistently for all the extension inits as well. Although i found it somewhat extensive and redundant initially, reading the docs i've discovered that it helps understand different types of initializations for layers. |
Personally I would rather not list all parameters in the summary. That's why they're document as arguments of the initializer anyway. Listing them is redundant and also makes the documentation harder to maintain, as also indicated by this PR. :) |
@eaplatanios, I think the current norm as far as layers are concerned is to write description for every function. Since the docs are generated from the files, have all functions including init. We could look at a format where in we avoid redundancy atleast in the parent layer functions by not describing the init since we already have parameter descriptions. |
The error :
|
Oh I'll have to merge master. Probably. Will do that in a second. |
Could you please do a pull from master? |
Yep, you beat me to it :) |
Can this be merged? |
Looks like #275 didn't update a few places of the documentation to reflect dilation.