Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Make liveness tracking of LazyTensorOperations a thread local state. #372

Merged
merged 5 commits into from
Jul 17, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Jul 17, 2019

No description provided.

@bgogul bgogul requested a review from pschuh July 17, 2019 18:40
@bgogul bgogul force-pushed the thread_local_ref_counts branch from e7ddb73 to c08f706 Compare July 17, 2019 18:40
@@ -0,0 +1,73 @@
/// A class to keep track of runtime information about `LazyTensorOperation`
/// instances created by the program. This will be manaaged as a thread local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manaaged ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. fixed now. :)

@rxwei
Copy link
Contributor

rxwei commented Jul 17, 2019

You could put all thread-local stuff into Context as private/internal properties, and deprecate _ThreadLocalState.

@bgogul
Copy link
Contributor Author

bgogul commented Jul 17, 2019

You could put all thread-local stuff into Context as private/internal properties, and deprecate _ThreadLocalState.

Good idea. Let me do that in a follow up PR.

@bgogul bgogul merged commit 97ca18b into tensorflow:master Jul 17, 2019
@bgogul bgogul deleted the thread_local_ref_counts branch July 17, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants