This repository was archived by the owner on Jul 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 137
Make liveness tracking of LazyTensorOperations
a thread local state.
#372
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c3748b5
Move liveness tracking logic to LazyTensorOperationsTracker.swift.
bgogul 3bc0430
Make Liveness tracking a thread local state.
bgogul f3b3e40
Renaming LazyTensorOperationsTracker -> LazyTensorContext
bgogul c08f706
Update comment on Runtime.swift.
bgogul b6481b8
fix a typo.
bgogul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/// A class to keep track of runtime information about `LazyTensorOperation` | ||
/// instances created by the program. This will be manaaged as a thread local | ||
/// state. | ||
class LazyTensorOperationsTracker { | ||
struct RefCounts { | ||
let op: LazyTensorOperation | ||
let liveRefCount: Int | ||
let allRefCount: Int | ||
} | ||
|
||
private var refCounts: [ObjectIdentifier: RefCounts] = [:] | ||
|
||
func incrementRefCount(_ op: LazyTensorOperation, isLive: Bool) { | ||
let opID = ObjectIdentifier(op) | ||
if let counts = refCounts[opID] { | ||
refCounts[opID] = RefCounts( | ||
op: op, | ||
liveRefCount: counts.liveRefCount + (isLive ? 1 : 0), | ||
allRefCount: counts.allRefCount + 1) | ||
} else { | ||
refCounts[opID] = RefCounts( | ||
op: op, liveRefCount: isLive ? 1 : 0, allRefCount: 1) | ||
} | ||
} | ||
|
||
func decrementRefCount(_ op: LazyTensorOperation, isLive: Bool) { | ||
let opID = ObjectIdentifier(op) | ||
if let counts = refCounts[opID] { | ||
if counts.allRefCount > 1 { | ||
refCounts[opID] = RefCounts( | ||
op: op, | ||
liveRefCount: counts.liveRefCount - (isLive ? 1 : 0), | ||
allRefCount: counts.allRefCount - 1) | ||
} else { | ||
refCounts.removeValue(forKey: opID) | ||
} | ||
} | ||
} | ||
|
||
func isLive(_ op: LazyTensorOperation) -> Bool { | ||
let opID = ObjectIdentifier(op) | ||
if let counts = refCounts[opID] { | ||
return counts.liveRefCount > 0 | ||
} | ||
return false | ||
} | ||
|
||
func forEachLiveOperation( | ||
_ perform: (LazyTensorOperation) throws -> Void | ||
) rethrows -> Void { | ||
for (_, counts) in refCounts where counts.liveRefCount > 0 { | ||
try perform(counts.op) | ||
} | ||
} | ||
|
||
func forEachOperation( | ||
_ perform: (LazyTensorOperation) throws -> Void | ||
) rethrows -> Void { | ||
for (_, counts) in refCounts { try perform(counts.op) } | ||
} | ||
} | ||
|
||
struct LazyTensorContext { | ||
var scopes = [LazyTensorOperationsTracker()] | ||
|
||
static private var threadLocalContext: LazyTensorContext { | ||
_ThreadLocalState.local.lazyTensorContext | ||
} | ||
|
||
static var operationsTracker: LazyTensorOperationsTracker { | ||
return threadLocalContext.scopes.last! | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manaaged ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah. fixed now. :)