This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Shape inference of simple operations in LazyTensor. #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaplatanios
reviewed
Jul 25, 2019
bgogul
changed the title
|
Folks, this PR is ready for review. |
eaplatanios
reviewed
Aug 1, 2019
|
Gentle ping. Can someone take a look at this PR, please? |
rxwei
reviewed
Aug 5, 2019
| @@ -62,12 +62,22 @@ class LazyTensorOperationsTracker { | |||
|
|
|||
| struct LazyTensorContext { | |||
| private var operationsTracker = LazyTensorOperationsTracker() | |||
| private var _shapeTrackingEnabled = true | |||
|
|
|||
| static private var threadLocalContext: LazyTensorContext { | |||
There was a problem hiding this comment.
Consider renaming to just local. It's a convention used in a lot of other Swift APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates shape tracking in lazy tensor by using the shape inference functions associated with the TF operations.