This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Reverting inference behavior for BatchNorm #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Aug 8, 2019
|
I wonder if it's possible to check in a "MiniGo shape mismatch reproducer" test to ensure the bug in #384 won't happen again? (I don't mean to block progress at all) |
|
That's a good idea. We need any kind of inference tests for BatchNorm and LayerNorm, because I believe both are only tested under training conditions. That would also help verify numerical correctness, like has been done on the training side. |
|
I don't really understand why these reshapes were there. I'm preparing another PR that removes them from a couple other places where they also shouldn't be. |
eaplatanios
added a commit
to eaplatanios/swift-apis
that referenced
this pull request
Aug 9, 2019
eaplatanios
added a commit
that referenced
this pull request
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts inference behavior for BatchNorm to what it was before PR #384. The reshaping introduced there was triggering shape mismatches in the MiniGo tests and preventing the demo from running due to runtime errors.