This repository was archived by the owner on Jul 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 137
Normalization layers fix (fixes #384 and #426). #428
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@BradLarson could you please verify if your use cases works fine with these changes? |
mikowals
reviewed
Aug 9, 2019
rxwei
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait on @BradLarson's review too.
BradLarson
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes tests on my end. We should still put in inference tests for BatchNorm at some point, but I can work on that.
Great, thanks @BradLarson! |
@BradLarson I have an test that is part of #429. I will make it part of a separate pull request later today. |
@mikowals - Excellent, thanks. Better test coverage overall is definitely something we're interested in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the shape related issues in the normalization layers (i.e., fixes #384 and #426). The role of
LayerNorm
is unclear to me currently as I believe it's not really the same as the layer norm in the Python API. In either case, this PR fixes shape issues in a principled way. We can deal with whatLayerNorm
is supposed to be later.cc @rxwei @BradLarson @mikowals