feat: Add support for security group referencing to transit-gateway module

[syedimranhassan]

…odule

Added support for security_group_referencing_support in the transit-gateway module.

Description

Motivation and Context

AWS recently introduced [HERE] security group referencing for Transit Gateway VPC attachments. This feature was available in the standalone resource aws_ec2_transit_gateway_vpc_attachment but not in the transit-gateway module. Added support for it in the module.

Breaking Changes

no

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[jhenry82]

Would love to see this too! One comment, this new setting exists at the Transit Gateway level too, not just attachments. So the module should also have a new variable for whether to enable it on the TGW. See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ec2_transit_gateway

[syedimranhassan]

@jhenry82 Thank you for pointing that out. I've updated the code to include SG referencing support at the TGW level as well.

[syedimranhassan]

@jhenry82 Can you please review this?

[jhenry82]

I am not a maintainer of this module, my review wouldn't mean much :) I just use the module and came here to see if the feature had been added, and saw your MR. Hopefully it is able to be integrated soon.

[syedimranhassan]

@antonbabenko @bryantbiggs Can you please review this PR?

[fintonic-plaform]

We also need this functionality.

[tigpt]

BUMP we need this.

[savealive]

Can we get this feature released?

[tigpt]

since no activity from the main maintainer, can @syedimranhassan host this fork on terraform registry so I can reference your fork instead of the main project? as a temporary measure.
Thanks

[tigpt]

I published it myself to be able to use it, feel free to use until official support.

https://registry.terraform.io/modules/tigpt/transit-gateway/aws/latest

module "tgw" {
source = "tigpt/transit-gateway/aws"
version = "2.12.4"

...
}

All credits go to @syedimranhassan for the work on the PR. Thanks ❤️

[lostsnow]

We also need this functionality.

[savealive]

@antonbabenko could you approve this PR please?

[antonbabenko]

This PR is included in version 2.13.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.