Skip to content

fix: Adjust aws provider requirements. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

markshawtoronto
Copy link

@markshawtoronto markshawtoronto commented Jan 16, 2025

Description

Using security_group_referencing_support added in release 2.13.0 requires at least aws provider v5.69.0.

Motivation and Context

Fixes #137

Breaking Changes

NEW: Yes, it's a breaking change, the issue is v2.13.0 does not work without it. Feel free to takeover this PR.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@markshawtoronto markshawtoronto changed the title Adjust aws provider requirements. fix: Adjust aws provider requirements. Jan 16, 2025
@markshawtoronto markshawtoronto marked this pull request as ready for review January 16, 2025 15:43
@bryantbiggs
Copy link
Member

thats a breaking change and should go out in #113

the issue is that #133 introduced it - @antonbabenko do we roll forward with the complete breaking change, or roll back?

@antonbabenko
Copy link
Member

@bryantbiggs I missed that version bump when merging #133.

I was unaware of the progress on #113, which looks great. If we can get it released shortly, we can skip thinking about fixing the issue introduced.

But in general, we can probably roll forward with the fix based on this PR (#138) without making a major release.

WDYT?

@bryantbiggs
Copy link
Member

Ya I supposed - 6 vs half a dozen at this point. I'll take a look at #113 and wrap that up shortly

@bspach
Copy link

bspach commented Feb 3, 2025

@bryantbiggs ETA for this fix to roll out?

Copy link

github-actions bot commented Mar 6, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 6, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Mar 16, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Validate failed on Release 2.13.0
4 participants