Skip to content

chore(ci): clean up validate scripts to remove duplication #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021
Merged

chore(ci): clean up validate scripts to remove duplication #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ jobs:
env:
HUSKY_SKIP_INSTALL: true

- name: Use React version
run: npm install --save-dev react@"${{ matrix.react }}" react-dom@"${{ matrix.react }}" react-test-renderer@"${{ matrix.react }}"
- name: ⚛️ Use React version
run: REACT_VERSION=${{ matrix.react }} npm run install:react

- name: ▶️ Run validate script
run: npm run validate
Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@
"docs:dev": "docz dev",
"docs:build": "docz build",
"contributors:add": "all-contributors add",
"install:react-16-9": "npm install --no-save [email protected] [email protected] [email protected]",
"install:react-16": "npm install --no-save react@^16 react-dom@^16 react-test-renderer@^16",
"install:react-17": "npm install --no-save react@^17 react-dom@^17 react-test-renderer@^17"
"install:react": "npm install --no-save react@${REACT_VERSION:-latest} react-dom@${REACT_VERSION:-latest} react-test-renderer@${REACT_VERSION:-latest}",
"install:react-16.9.0": "cross-env REACT_VERSION=16.9.0 npm run install:react",
"install:react-16": "cross-env REACT_VERSION=^16 npm run install:react",
"install:react-17": "cross-env REACT_VERSION=^17 npm run install:react"
},
"dependencies": {
"@babel/runtime": "^7.12.5",
Expand All @@ -59,6 +60,7 @@
"@typescript-eslint/parser": "4.28.5",
"all-contributors-cli": "6.20.0",
"codecov": "3.8.3",
"cross-env": "^7.0.3",
"docz": "2.3.1",
"docz-theme-default": "1.2.0",
"docz-utils": "2.3.0",
Expand Down