[Fix] Avoid break on assert if security node is missing in config #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was looking to fix #247 (but this PR is not related to the issue), so I've tried to install the bundle on a fresh new (light) Symfony.
Then when the cache:clear occurs, I had the following error :
The problem is the
assert
about thesecurity
node.But that node is not mandatory as we have default values for
enable_login
&enable_me
(and as the doc says, we have to set them only if we want to customize).But then I noticed the assert was required by PHPStan level, so the fix should be to set an empty array for
security
if none is already set.Note
I will open an other following PR about the CI because currently assert are bypassed by the PHP used in CI, which is why tests succeed.