[CI] Set zend.assertions to 1 ini PHP Setup to break on asserts #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on master to check whether we will have green CI.
👍 |
cvergne
force-pushed
the
ci/set-php-zend-assertion
branch
from
ee18aa5 to
de49176
Compare
|
Rebase done, and green CI :) |
|
Thank you @cvergne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As mentioned in #249, currently the CI tests doesn't break on PHP
assertbecausezend.assertionsis not set by default to1on the config currently used by setup-php action.Cf. shivammathur/setup-php#582
Tests on this PR should break so because of assert on security config node, fixed by #249.
Note
I've only set the
zend.assertionsconfig here, but it might be better to useini-file: developmentinstead which use a PHP ini config file for development. But maybe it will break more with it so we should try it later.