Skip to content

Upgrade to Graphqlite 5 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Upgrade to Graphqlite 5 #59

wants to merge 1 commit into from

Conversation

devmaslov
Copy link
Collaborator

@devmaslov devmaslov commented Oct 27, 2021

I'm onto updating the Symfony bundle and this lib has gotten in the way. So it should be updated first.

@moufmouf I don't have rights to merge this PR and tag the version. Could you do that? Or grant the permissions to me?
BTW, I'm curious why this logic was separated from the main bundle?

@moufmouf
Copy link
Member

Hey @devmaslov ,

Sorry about that, you should have received an invite right now to be maintainer of this package too.

This package is separated from the Symfony bridge because some projects are using this package without Symfony.

For instance, if you have a project based on a PSR-15 middleware like Laminas, it is absolutely possible to use the Symfony validator without Symfony. Hence the need to make it separate from the Symfony bundle.
And I did not put it into GraphQLite itself because I wanted to avoid the dependency of GraphQLite on a given version of the Symfony validator package.

@devmaslov
Copy link
Collaborator Author

@moufmouf got it, thanks!

@devmaslov
Copy link
Collaborator Author

Closing as a duplicate of #60

@devmaslov devmaslov closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants