Skip to content

Upgrade dependencies to prepare 5.0.0 release #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 29, 2021
Merged

Upgrade dependencies to prepare 5.0.0 release #60

merged 10 commits into from
Oct 29, 2021

Conversation

dsavina
Copy link
Collaborator

@dsavina dsavina commented Oct 28, 2021

No description provided.

@dsavina dsavina changed the title Upgrade dependencies to prepare 5.0 release Upgrade dependencies to prepare 5.0.0 release Oct 28, 2021
@moufmouf
Copy link
Member

This seems to be also done in #59
@dsavina @devmaslov Could you guys take a look at each others PR and try to merge both in one?

devmaslov
devmaslov reviewed Oct 28, 2021
View reviewed changes
src/ConstraintViolationException.php
Comment on lines +49 to +54
if (! empty($code)) {
$extensions['code'] = $code;
}

$propertyPath = $this->violation->getPropertyPath();
if ($propertyPath !== null) {
if (! empty($propertyPath)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was too quick in my PR with fixing the unit tests like this: https://github.com/thecodingmachine/graphqlite-symfony-validator-bridge/pull/59/files#diff-02c6aa7ec0feccd57d011c4811afe16fab28e8c1e7e517028100a96fd7a4d3f5R18-R21

This makes more sense.

devmaslov
devmaslov approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@devmaslov devmaslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsavina @moufmouf
This PR covers more ground. I think it's ready to go live. Nice work!

@moufmouf
Copy link
Member

@dsavina I think you need to update the "master" alias in composer.json (just like @devmaslov did in #59 )

@dsavina dsavina force-pushed the chore/general-upgrade branch from ed6d45b to d0aa86f Compare October 28, 2021 14:47
@dsavina
Copy link
Collaborator Author

dsavina commented Oct 28, 2021 •
edited
Loading

Thanks for the review!

@devmaslov, I'm so sorry, I hadn't seen you also created a Merge Request on this matter, I didn't mean to be rude.

@moufmouf, I just updated the branch alias to 5.0.x-dev.

I also took the liberty to rename all occurrences of Graphqlite to GraphQLite, for more consistency (cf. #8). I'll do the same on thecodingmachine/graphqlite-bundle once this is merged.

@dsavina dsavina mentioned this pull request Oct 28, 2021
Closed
@dsavina dsavina requested a review from devmaslov October 29, 2021 07:54
This was referenced Oct 29, 2021
Closed
Closed
@devmaslov
Copy link
Collaborator

@dsavina It's ok 🙂

@dsavina dsavina merged commit a2a9ae1 into thecodingmachine:master Oct 29, 2021
@dsavina
Copy link
Collaborator Author

dsavina commented Oct 29, 2021

Merged, thanks!

@dsavina dsavina mentioned this pull request Nov 2, 2021
Closed
@devmaslov devmaslov mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmaslov devmaslov devmaslov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsavina @moufmouf @devmaslov