Skip to content

Added documentation for the stat/geom_contour. #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JHonaker
Copy link

@JHonaker JHonaker commented Oct 3, 2018

Referencing #2472, I added the parameters bins, binwidth, and breaks to the stat_contour and geom_contour parameter lists. For some reason they were undocumented (except in the examples), but still available for use.

There was also an unused parameter "complete." I couldn't find any reference to it in either function, so I removed it as well. If there's a reason that it shouldn't be removed, like a future feature, I can revert it.

Bins, binwidth, and breaks were undocumented.
The unused parameter "complete" was removed as well.
@paleolimbot
Copy link
Member

Thank you for submitting this PR! I'm sorry it took such a long time for us to look at it...you are absolutely right that the complete parameter didn't do anything...in a subsequent PR it was removed, and at Tidy Dev Day this year there was another PR that further documented geom/stat_contour(). I believe the reason the PR wasn't reviewed immediately was because you didn't run devtools::document() after updating the source files, and it takes a bit of effort for a maintainer to do that and push the changes to the PR.

@clauswilke
Copy link
Member

I'm closing this PR, since the issue has been addressed since.

@clauswilke clauswilke closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants