Skip to content

Document breaks/bins/binwidth parameters in stat/geom contour #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sinarueeger
Copy link
Contributor

  • Added explicit breaks, nbin and binwidth arguments to stat_contour() and geom_contour(), along with documentation for stat_contour().

  • In the parameter description, I added a default value to breaks. Not sure this is ok, as it is the default value to all parameter (when breaks=NULL, nbin=NULL, binwidth=NULL).

Closes #2472.

@sinarueeger
Copy link
Contributor Author

sinarueeger commented Jul 8, 2019

Questions

@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 8, 2019
@paleolimbot
Copy link
Member

Thanks for this PR! Yesterday another PR got merged that fixed the unused complete parameter (and implemented some new features), and resolving the merge conflict between that PR and this one was tough! I made sure your documentation for breaks/bins/binwidth made it through the merge resolution, but could you add a NEWS bullet (after doing a Pull from the git tab in RStudio)?

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was just reminded that NEWS bullets aren't required for documentation fixes. Thank you for this PR!

@paleolimbot paleolimbot merged commit a7c1138 into tidyverse:master Jul 17, 2019
@sinarueeger
Copy link
Contributor Author

Excellent - thanks @paleolimbot for merging + thanks for carrying my changes through the merge conflicts!

@sinarueeger sinarueeger deleted the issue-2472-document-breaks-param-in-stat_contour branch July 17, 2019 07:41
@lock
Copy link

lock bot commented Jan 13, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stat_contour's breaks parameter is undocumented
3 participants