-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Document breaks/bins/binwidth parameters in stat/geom contour #3423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document breaks/bins/binwidth parameters in stat/geom contour #3423
Conversation
…nto the parameter list params.
Questions
|
Thanks for this PR! Yesterday another PR got merged that fixed the unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was just reminded that NEWS bullets aren't required for documentation fixes. Thank you for this PR!
Excellent - thanks @paleolimbot for merging + thanks for carrying my changes through the merge conflicts! |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Added explicit
breaks
,nbin
andbinwidth
arguments tostat_contour()
andgeom_contour()
, along with documentation forstat_contour()
.In the parameter description, I added a default value to
breaks
. Not sure this is ok, as it is the default value to all parameter (whenbreaks=NULL
,nbin=NULL
,binwidth=NULL
).Closes #2472.