Skip to content

Expanded documentation for aes-colour-fill-alpha #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2020
Merged

Expanded documentation for aes-colour-fill-alpha #3786

merged 6 commits into from
May 2, 2020

Conversation

kelseymoty
Copy link
Contributor

Expanded documentation for aes-colour-fill-alpha addresses one of the points raised in issue #3297

@hadley hadley added the tidy-dev-day 🤓 Tidyverse Developer Day label Jan 31, 2020
@clauswilke clauswilke mentioned this pull request Feb 1, 2020
Merged
@clauswilke
Copy link
Member

See also #3788.

clauswilke
clauswilke requested changes Feb 2, 2020
View reviewed changes
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I've made a few comments that should be addressed. In addition, please merge in the current github master, so the automated tests start working again. Thanks!

@thomasp85
Copy link
Member

@kelseymoty, are you interested in finishing this off?

@thomasp85 thomasp85 added this to the ggplot2 3.3.1 milestone Mar 9, 2020
clauswilke
clauswilke approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added the minor fixes I had requested.

@clauswilke clauswilke merged commit e5d2747 into tidyverse:master May 2, 2020
@clauswilke
Copy link
Member

Thanks, this will be included in the next ggplot2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kelseymoty @clauswilke @thomasp85 @hadley