Skip to content

improve aesthetic documentation #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 16, 2020
Merged

improve aesthetic documentation #3788

merged 10 commits into from
May 16, 2020

Conversation

rivaquiroga
Copy link
Contributor

Closes #3293

clauswilke
clauswilke reviewed Feb 1, 2020
View reviewed changes
@clauswilke
Copy link
Member

This PR and #3786 by @kelseymoty touch the same file and cannot be both merged without conflict. Since #3786 is smaller in scope, it should probably be merged first.

@clauswilke clauswilke mentioned this pull request Feb 1, 2020
Merged
@clauswilke clauswilke added the tidy-dev-day 🤓 Tidyverse Developer Day label Feb 1, 2020
@thomasp85 thomasp85 added this to the ggplot2 3.3.1 milestone Mar 9, 2020
@clauswilke
Copy link
Member

@rivaquiroga PR #3786 has now been merged. Do you want to update your PR so it can be merged as well? The first step would be to merge in the current master branch and fix any conflicts. You may simply want to discard your changes to the file aes-colour-fill-alpha.r, or maybe carry over only the changes to examples.

@thomasp85
Copy link
Member

@clauswilke do you want to finish this off?

@clauswilke
Copy link
Member

Sure, I'll do it.

clauswilke added 6 commits May 15, 2020 17:34
@clauswilke
merge in master, update docs
d919649 
Merge branch 'master' into rivaquiroga-aes-documentation

# Conflicts:
#	R/aes-colour-fill-alpha.r
#	man/aes_colour_fill_alpha.Rd
@clauswilke
clean up colour fill alpha docs
e156ebd
@clauswilke
clean up aes group order
2a9ec09
@clauswilke
cleanup linetype size shape
9d657b8
@clauswilke
clean up aes position
c49077b
@clauswilke
minor cleanup
77ece50
@clauswilke clauswilke requested a review from paleolimbot May 15, 2020 23:53
@clauswilke
Copy link
Member

@paleolimbot Could you look this over, since you filed the original issue? I'm done with cleaning this up.

paleolimbot
paleolimbot approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to leave or take! I think I had something in mind when I opened the issue about making rd_aesthetics() a bit smarter (maybe even link to these pages), but that's a battle for another day.

@clauswilke clauswilke merged commit 0f725e1 into tidyverse:master May 16, 2020
@clauswilke
Copy link
Member

Thanks @rivaquiroga, this will be part of the next ggplot2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke left review comments

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve aesthetic documentation
4 participants
@rivaquiroga @clauswilke @thomasp85 @paleolimbot