Update geom-text.r

[larspijnappel]

As proposed, here's a PR for the documentation improvement regarding the unsupported check_overlap argument for geom_label() (#4331).

If this is not sufficient, please advise me on the necessary improvements, as this is my first contribution.

[yutannihilation]

Thanks, a minor comment.

[thomasp85]

@larspijnappel do you want to finish this off?

[larspijnappel]

Hi @thomasp85,

I certainly wish to, but I'm afraid that it's unclear for me what the next-best-action needs to be done (TBH, the GitHub process is a bit overwhelming for me as newbie).

I agree with the feedback from reviewer yutannihilation, but I fail to see if I'm supposed to do something and, if so, how to do that.

Thanks for helping me out.

[thomasp85]

No problem @larspijnappel — there is definitely a learning curve for all this 🙂

If you look at your own GitHub repository list you can see that you have a fork of ggplot2. This fork contains a branch which is the basis of this PR - you can see the branch name in the top of the PR

Any changes to this branch will be reflected in this PR, which is how it is possible to have back-and-forths in a PR with code changes along the way

Are you familiar with working with git from rstudio?

[larspijnappel]

Yes, I do use git in RStudio, but only for personal use.
Unfortunately, I cannot find my larspijnappel-patch-1 in my GitHub repo anymore..

So, would it best to redo it again: make new fork > apply change > create new pull request?

[thomasp85]

Yeah, let's start over. I would suggest that you look into the pr_ functions in usethis as these are designed to enforce good practice around creating PRs. See this page on how to get started https://usethis.r-lib.org/articles/articles/pr-functions.html

[larspijnappel]

Hi @thomasp85,

Thx very much for the redirection to the very clear written pages of usethis. I've succeeded in completing this new approach and submitted a new PR #4389.