Update geom-text.r #4389
Merged
Update geom-text.r #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the unsupported `check_overlap` argument for `geom_label()` (tidyverse#4331).
Closed
|
Can I get you to run roxygen to also update the docs |
|
No problem, although that would be another first time for me as well :-) So, in my local branch I performed Do I just |
|
Yes - every change can be added to the PR using |
thomasp85
requested changes
Apr 9, 2021
NAMESPACE
Outdated
| @@ -489,6 +489,7 @@ export(scale_color_fermenter) | |||
| export(scale_color_gradient) | |||
| export(scale_color_gradient2) | |||
| export(scale_color_gradientn) | |||
| export(scale_color_gray) | |||
There was a problem hiding this comment.
Can I get you to remove the two new exports in the NAMESPACE... It is not your fault, but another PR did not get oxygenised and this is now causing your PR to fail check. Removing these lets us handle it in a different PR
NAMESPACE
Outdated
| @@ -536,6 +537,7 @@ export(scale_fill_fermenter) | |||
| export(scale_fill_gradient) | |||
| export(scale_fill_gradient2) | |||
| export(scale_fill_gradientn) | |||
| export(scale_fill_gray) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed, here's a PR for the documentation improvement regarding the unsupported
check_overlapargument forgeom_label()(#4331).Note: this request replaces the previous PR #4332 as it can't be completed due to loss of the previous fork.