Skip to content

Switch to vdiffr 1.0.0 snapshots #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Switch to vdiffr 1.0.0 snapshots #4503

merged 2 commits into from
Jun 9, 2021

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Jun 8, 2021

See https://vdiffr.r-lib.org/news/index.html#vdiffr-1-0-0-2021-06-08 (blog post upcoming).

Practically, the switch to testthat 3e means that figures are now stored in tests/testthat/_snaps/ instead of tests/figs/. This causes several plots to hit the 100 character limits for relative paths inside a package. To work around this I have shortened several titles in the second commit.

The SVG engine update causes a few differences in snapshots. I have reviewed all of them and the changes seem fine:

  • Points now look smaller. They actually have the expected size.
  • Some textboxes have slightly different extents, which is expected.
  • Colour gradients in legends now fit their boxes better.

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Other than the actual SVG files are too many to review one by one (I believe you), looks good to me! Do you think we should include this in the upcoming version (v3.3.4) of ggplot2 as well?

@lionel-
Copy link
Member Author

lionel- commented Jun 9, 2021

Do you think we should include this in the upcoming version (v3.3.4) of ggplot2 as well?

I believe there would be no harm in including it but there is no rush.

@thomasp85
Copy link
Member

The 3.3.4-rc is frozen at this point so we will just wait for the next (bigger) release

@yutannihilation
Copy link
Member

Okay, if it's not necessary to include this, let's wait for the next release (with migration to testthat 3e). Thanks for confirming!

@yutannihilation yutannihilation merged commit 01fe5de into master Jun 9, 2021
@lionel- lionel- deleted the vdiffr-1-0-0 branch June 9, 2021 13:24
@yutannihilation yutannihilation mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants