Skip to content

Use testthat 3e #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 9, 2021
Merged

Use testthat 3e #4522

merged 9 commits into from
Nov 9, 2021

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Jun 18, 2021

Now that vdiffr doesn't depend on context() (c.f., #4503), it's possible to migrate to testthat 3e.

  • Remove context()
  • expect_is() -> expect_s3_class() or expect_type()
  • expect_equivalent() -> expect_equal(ignore_attr = TRUE)
  • Let expect_equal() ignore the environments of quosures
  • Ignore multiple warnings as expect_warning() now captures only one warning
  • Skip the test about stringsAsFactors on R >=4.0

@yutannihilation yutannihilation marked this pull request as ready for review June 18, 2021 15:07
@yutannihilation
Copy link
Member Author

This should be ready now.

@thomasp85 thomasp85 merged commit ad3dbfc into tidyverse:main Nov 9, 2021
@thomasp85
Copy link
Member

Thanks! took the liberty of merging myself so the test setup is updated ASAP

@yutannihilation
Copy link
Member Author

Thanks for merging!

@yutannihilation yutannihilation deleted the test/testthat-3e branch November 9, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants