Update errors, warnings, and messages to cli #4796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Apr 10, 2022
|
(Also needs redocumenting to fix the build errors) |
thomasp85
commented
Apr 19, 2022
Co-authored-by: Hadley Wickham <[email protected]>
hadley
reviewed
Apr 19, 2022
Co-authored-by: Hadley Wickham <[email protected]>
|
@hadley all errors except for a few special concessions have now been covered with tests |
hadley
approved these changes
May 12, 2022
| @@ -199,7 +197,7 @@ Layer <- ggproto("Layer", NULL, | |||
| } else if (is.function(self$data)) { | |||
| data <- self$data(plot_data) | |||
| if (!is.data.frame(data)) { | |||
| abort("Data function must return a data.frame") | |||
| cli::cli_abort("{.fn layer_data} must return a {.cls data.frame}") | |||
There was a problem hiding this comment.
The plan is to work through all the call arguments in the next PR?
There was a problem hiding this comment.
yes - the places where it is needed
thomasp85
commented
May 17, 2022
thomasp85
commented
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all user messaging to use the cli framework for proper formating. This PR is almost a direct translation from the old behaviour, but it does include a few refactors to make the code simpler where possible, using e.g. the auto collapsing feature of cli.
The changes has led to a few failing tests. These tests have been updated to use the new
expect_snapshot_*()functions to better handle messages with formating.This PR will be followed an additional PR looking into better error message chaining to let users know where errors occurred during rendering