Skip to content

Improve error messages when base pipe operator is used wrongly #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

92amartins
Copy link
Contributor

This PR is an attempt to fix #4792.

I tried to follow the @yutannihilation guidelines on the original issue.

Couldn't figure it out how to include proper snaps.

Further guidance is greatly appreciated

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Co-authored-by: Hiroaki Yutani <[email protected]>
@yutannihilation
Copy link
Member

The CI failure is a temporary one due to the release of R 4.2. We can ignore it for now.

@yutannihilation
Copy link
Member

@92amartins
I'm really sorry I didn't notice it, but #4796 already included the same change. I appreciate your contribution, but I'm closing this to avoid possible conflicts with #4796...

@92amartins 92amartins deleted the 4792-base-pipe-operator-msg branch April 25, 2022 17:43
@92amartins
Copy link
Contributor Author

@yutannihilation no problem! I'll search for other good issues to contribute (using the good first issue and help wanted labels). Let me know if you have any advice for my first contribution.

@yutannihilation
Copy link
Member

The ones with "good first issue" label should be good for the first contribution!

https://github.com/tidyverse/ggplot2/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue+%3Aheart%3A%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggested tweak to the error message in validate_mapping()
2 participants