Skip to content

Fix CI failures on oldrel-4 (i.e. R 3.5) #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Nov 30, 2022

Currently the CI fails with this error:

   Error: 
  ! error in pak subprocess
  Caused by error: 
  ! Cannot install packages:
  * deps::.: Can't install dependency quantreg
  * quantreg: Can't install dependency MatrixModels
  * MatrixModels: Needs R >= 3.6.0

This pull request bumps the version of ignore-before-r for quantreg, and remove unnecessary ignore-before-r as the oldest one is now R 3.5.

Also, it seems warnPartialMatchArgs did not accept FALSE at the time of R 3.5. So this pull request skips the tests on R < 3.6.

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (???): geom_quantile matches quantile regression ──────────────────────
Error in `options(old_options)`: invalid value for 'warnPartialMatchArgs'
Backtrace:
    ▆
 1. └─withr (local) `<fn>`(`<env>`)

[ FAIL 1 | WARN 0 | SKIP 77 | PASS 1846 ]

@yutannihilation yutannihilation changed the title Ignore installation failures of quantreg on R 3.5 Fix CI failures on oldrel-4 (i.e. R 3.5) Nov 30, 2022
@yutannihilation
Copy link
Member Author

@thomasp85 @clauswilke @karawoo
Sorry to bother you, can anyone approve this to fix the CI?

Copy link
Member

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@yutannihilation
Copy link
Member Author

Thanks for approving!!

@yutannihilation yutannihilation merged commit b118168 into main Dec 11, 2022
@yutannihilation yutannihilation deleted the yutannihilation-patch-1 branch December 11, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants