Skip to content

Fix CI failures on oldrel-4 (i.e. R 3.5) #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Fix CI failures on oldrel-4 (i.e. R 3.5) #5068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
390c5ed
Ignore installation failures of quantreg on R 3.5
yutannihilation Nov 30, 2022
e34b32c
Skip tests using warnPartialMatchArgs=FALSE on R 3.5
yutannihilation Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,8 @@ jobs:
cache-version: 2
extra-packages: >
any::rcmdcheck,
maps=?ignore-before-r=3.5.0,
Hmisc=?ignore-before-r=3.6.0,
mapproj=?ignore-before-r=3.5.0,
multcomp=?ignore-before-r=3.5.0,
quantreg=?ignore-before-r=3.5.0,
quantreg=?ignore-before-r=3.6.0,
needs: check

- uses: r-lib/actions/check-r-package@v2
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-geom-quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
test_that("geom_quantile matches quantile regression", {
skip_if(packageVersion("base") < "3.6.0") # warnPartialMatchArgs didn't accept FALSE
withr::local_options(
warnPartialMatchArgs = FALSE,
warnPartialMatchDollar = FALSE
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-geom-smooth.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ test_that("geom_smooth works in both directions", {
})

test_that("default smoothing methods for small and large data sets work", {
skip_if(packageVersion("base") < "3.6.0") # warnPartialMatchArgs didn't accept FALSE
withr::local_options(warnPartialMatchArgs = FALSE)
# Numeric differences on the MLK machine on CRAN makes these test fail
# on that particular machine
Expand Down