Skip to content

Use scales::label_* over scales::*format()` #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 31, 2023

Also added a period at the end of the check_installed() messages for consistency. https://style.tidyverse.org/error-messages.html

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good to me, thanks for the contribution!

@teunbrand teunbrand merged commit fc830ce into tidyverse:main Nov 2, 2023
@olivroy olivroy deleted the scales branch November 2, 2023 12:08
teunbrand added a commit to teunbrand/ggplot2 that referenced this pull request Nov 8, 2023
teunbrand added a commit that referenced this pull request Dec 6, 2023
* set dotplot binwidth

* set number of bins

* fill in smooth defaults

* silence coord replacements

* stat_summary2d has been replace by stat_summary_2d

* fill quantile formula

* suppress scale type messages

* suppress sp-related messages

* use explicit tempfiles

* Include snapshot renaming from #5504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants