Skip to content

Silence tests #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Silence tests #5507

merged 13 commits into from
Dec 6, 2023

Conversation

teunbrand
Copy link
Collaborator

Some tests are emitting messages that are mildly distracting when looking at the output of devtools::test().
In this PR, I've silenced the messages that I found distracting, either by providing the defaults or suppressing messages that are thrown along with errors. In addition, I found that the check_device() tests were creating spurious files.

What messages are not fixed by this PR:

  • sf_transform_xy() warns a lot #5326
  • Sometimes dev.capabilities() used in check_device() throws a 'stack inbalance' message. For some reason, this only appears to occur when run in tests, but not in console, so I'm a bit puzzled still.

Copy link
Contributor

@olivroy olivroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is important. It would be great if this was merged! Especially for these forgotten snapshot updates by a certain person ;)

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Dec 5, 2023
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
Copy link
Collaborator Author

Thanks for the review Thomas!

@teunbrand teunbrand merged commit 5c7867d into tidyverse:main Dec 6, 2023
@teunbrand teunbrand deleted the silent_tests branch December 6, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants