-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Silence tests #5507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence tests #5507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is important. It would be great if this was merged! Especially for these forgotten snapshot updates by a certain person ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review Thomas! |
Some tests are emitting messages that are mildly distracting when looking at the output of
devtools::test()
.In this PR, I've silenced the messages that I found distracting, either by providing the defaults or suppressing messages that are thrown along with errors. In addition, I found that the
check_device()
tests were creating spurious files.What messages are not fixed by this PR:
dev.capabilities()
used incheck_device()
throws a 'stack inbalance' message. For some reason, this only appears to occur when run in tests, but not in console, so I'm a bit puzzled still.