Skip to content

Deploy refactor resolve step #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

codenem
Copy link
Contributor

@codenem codenem commented Jul 23, 2024

Closes #

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Ran e2e test suite and checked v3 catalog in dev mode.
Ran deploy test with local setup.


Changelog

Stop using esbuild metaOutput imports to build bundle package.json. This can be done because :

  • Direct dependencies metadata (version, external) is now collected before bundling since Monorepo packages automatic handling #1208
  • The previous way was to look for all bundle seen imports inside those direct dependencies
  • The fallback to a package.json dependencies then devDependencies then CLI dependencies check has been kept

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 3ed65ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenem codenem force-pushed the deploy-refactor-resolve-step branch from d1a5ec1 to 76a6feb Compare July 24, 2024 07:44
@codenem codenem force-pushed the deploy-refactor-resolve-step branch from 76a6feb to 333e611 Compare July 24, 2024 08:04
@codenem codenem marked this pull request as ready for review July 24, 2024 08:05
@matt-aitken
Copy link
Member

@ericallam I'm closing this because I know you used it as inspiration for your larger rewrite of the CLI bundling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants