Skip to content

Monorepo packages automatic handling #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

codenem
Copy link
Contributor

@codenem codenem commented Jul 9, 2024

Closes #

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Run the whole e2e suite


Changelog

  • Execute a direct dependencies listing before bundling to get information on whether those are internal or not.
  • Let esbuild bundle internal dependencies based on that information
  • Add fixtures for monorepo cases with workspaces depending on another.
  • Fix logging of error when listing dependencies

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: a1e7ded

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenem codenem force-pushed the monorepo-packages-automatic-handling branch 5 times, most recently from 2970a8a to c4d91d3 Compare July 16, 2024 09:28
@codenem codenem marked this pull request as ready for review July 16, 2024 09:30
@codenem codenem force-pushed the monorepo-packages-automatic-handling branch 2 times, most recently from 390b32f to 45b0ddd Compare July 17, 2024 07:35
@codenem codenem force-pushed the monorepo-packages-automatic-handling branch from 45b0ddd to a1e7ded Compare July 23, 2024 06:22
@ericallam ericallam merged commit ae9a8b0 into triggerdotdev:main Jul 23, 2024
2 checks passed
@codenem codenem mentioned this pull request Jul 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants