Skip to content

Deploy use pkg manager command only once #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

codenem
Copy link
Contributor

@codenem codenem commented Jul 15, 2024

Closes #

⚠️ Needs to be rebased after #1208 is merged

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Ran e2e test suite and checked v3 catalog in dev mode.


Changelog

Stop using esbuild metaOutput imports to build bundle package.json. This can be done because :

  • Direct dependencies metadata (version, external) is now collected before bundling since Monorepo packages automatic handling #1208
  • The previous way was to look for all bundle seen imports inside those direct dependencies
  • The fallback to a package.json dependencies then devDependencies then CLI dependencies check has been kept

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: df2dd73

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenem codenem force-pushed the deploy-use-pkg-manager-command-only-once branch from 2649d9e to ed5b5c4 Compare July 16, 2024 09:31
@codenem codenem force-pushed the deploy-use-pkg-manager-command-only-once branch 2 times, most recently from 6173b60 to 54ba542 Compare July 17, 2024 07:22
@codenem codenem force-pushed the deploy-use-pkg-manager-command-only-once branch from 54ba542 to 72312a9 Compare July 17, 2024 07:37
@codenem codenem closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant