v3: new build system fixes

.changeset/many-papayas-hope.md

@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fix entry point paths on windows

.changeset/smart-meals-join.md

@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Support custom config file names & paths

.changeset/witty-dancers-smash.md

@@ -0,0 +1,6 @@
+---
+"trigger.dev": patch
+"@trigger.dev/core": patch
+---
+
+Support for custom conditions

.github/workflows/e2e.yml

@@ -9,12 +9,13 @@ on:
         type: string
 jobs:
   cli-v3:
-    name: "🧪 CLI v3 tests"
+    name: "🧪 CLI v3 tests (${{ matrix.os }} - ${{ matrix.package-manager }})"
     if: inputs.package == 'cli-v3' || inputs.package == ''
-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
+        os: [buildjet-8vcpu-ubuntu-2204, windows-latest]
         package-manager: ["npm", "pnpm", "yarn"]
     steps:
       - name: ⬇️ Checkout repo
@@ -46,71 +47,8 @@ jobs:
         run: corepack enable
 
       - name: Run E2E Tests
+        shell: bash
         run: |
-          PM=${{ matrix.package-manager }} pnpm --filter trigger.dev run test:e2e
-  webapp:
-    name: "🧪 Webapp tests"
-    if: inputs.package == 'webapp' || inputs.package == ''
-    runs-on: buildjet-16vcpu-ubuntu-2204
-    steps:
-      - name: 🐳 Login to Docker Hub
-        uses: docker/login-action@v2
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME || vars.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN || vars.DOCKERHUB_TOKEN }}
-
-      - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-          submodules: recursive
+          LOG=debug PM=${{ matrix.package-manager }} pnpm --filter trigger.dev run test:e2e
 
-      - name: ⎔ Setup pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 8.15.5
 
-      - name: ⎔ Setup node
-        uses: buildjet/setup-node@v3
-        with:
-          node-version: 20.11.1
-          cache: "pnpm"
-
-      - name: 📥 Download deps
-        run: pnpm install --frozen-lockfile
-
-      - name: Install Playwright Browsers
-        run: npx playwright install --with-deps
-
-      - name: Run Playwright tests
-        run: |
-          # Setup environment variables
-          cp ./.env.example ./.env
-          cp ./references/nextjs-test/.env.example ./references/nextjs-test/.env.local
-
-          # Build packages
-          pnpm run build --filter @references/nextjs-test^...
-          cd apps/webapp && pnpm run build:server
-          cd ../..
-          pnpm --filter @trigger.dev/database generate
-          pnpm --filter @trigger.dev/otlp-importer generate
-
-          # Move trigger-cli bin to correct place
-          pnpm install --frozen-lockfile
-
-          # Execute tests
-          pnpm run docker
-          pnpm run db:migrate
-          pnpm run db:seed
-          pnpm run test:e2e
-
-          # Cleanup
-          pnpm run docker:stop
-
-      - name: Upload Playwright report
-        uses: actions/upload-artifact@v3
-        if: always()
-        with:
-          name: playwright-report
-          path: playwright-report/
-          retention-days: 30

.github/workflows/pr_checks.yml

@@ -21,9 +21,15 @@ jobs:
     uses: ./.github/workflows/unit-tests.yml
     secrets: inherit
 
+  e2e:
+    uses: ./.github/workflows/e2e.yml
+    with:
+      package: cli-v3
+    secrets: inherit
+
   preview-release:
     name: Preview Release
-    needs: [typecheck, units]
+    needs: [typecheck, units, e2e]
     if: |
       github.repository == 'triggerdotdev/trigger.dev'
     runs-on: buildjet-8vcpu-ubuntu-2204
@@ -52,9 +58,3 @@ jobs:
 
       - name: ⚡ publish preview release
         run: npx pkg-pr-new publish --no-template $(ls -d ./packages/*)
-
-  # e2e:
-  #   uses: ./.github/workflows/e2e.yml
-  #   with:
-  #     package: webapp
-  #   secrets: inherit

.github/workflows/typecheck.yml

@@ -29,4 +29,7 @@ jobs:
         run: pnpm run generate
 
       - name: 🔎 Type check
-        run: pnpm run typecheck --filter webapp
+        run: pnpm run typecheck
+
+      - name: 🔎 Check exports
+        run: pnpm run check-exports

.gitignore

@@ -53,5 +53,7 @@ apps/**/public/build
 /playwright/.cache/
 
 .cosine
-.trigger/
-.tshy*
+.trigger
+.tshy*
+.yarn
+*.tsbuildinfo

.vscode/launch.json

@@ -29,6 +29,14 @@
       "cwd": "${workspaceFolder}/references/job-catalog",
       "sourceMaps": true
     },
+    {
+      "type": "node-terminal",
+      "request": "launch",
+      "name": "Debug V3 init CLI",
+      "command": "pnpm exec triggerdev init",
+      "cwd": "${workspaceFolder}/references/init-shell",
+      "sourceMaps": true
+    },
     {
       "type": "node-terminal",
       "request": "launch",
@@ -76,6 +84,14 @@
       "port": 9229,
       "restart": true,
       "skipFiles": ["<node_internals>/**"]
+    },
+    {
+      "type": "node-terminal",
+      "request": "launch",
+      "name": "Debug CLI e2e tests",
+      "command": "PM=yarn pnpm run test:e2e",
+      "cwd": "${workspaceFolder}/packages/cli-v3",
+      "sourceMaps": true
     }
   ]
 }

docs/guides/new-build-system-preview.mdx

@@ -71,12 +71,12 @@ import { defineConfig } from "@trigger.dev/sdk/v3";
 export default defineConfig({
   project: "<project ref>",
   build: {
-    externals: ["native-module"],
+    external: ["native-module"],
   },
 });
 ```
 
-`externals` is an array of strings, where each string is the name of a dependency that should be made external. Glob expressions are also supported and use the [minimatch](https://github.com/isaacs/minimatch) matcher.
+`external` is an array of strings, where each string is the name of a dependency that should be made external. Glob expressions are also supported and use the [minimatch](https://github.com/isaacs/minimatch) matcher.
 
 ### `additionalFiles`
 

package.json

@@ -28,6 +28,7 @@
     "test": "turbo run test",
     "test:dev": "turbo run test:dev",
     "start": "turbo run start",
+    "check-exports": "turbo run check-exports",
     "clean": "turbo run clean",
     "clean:node_modules": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +",
     "typecheck": "turbo run typecheck",

packages/build/package.json

@@ -33,12 +33,32 @@
       "@triggerdotdev/source"
     ]
   },
+  "typesVersions": {
+    "*": {
+      "extensions": [
+        "dist/commonjs/extensions/index.d.ts"
+      ],
+      "extensions/core": [
+        "dist/commonjs/extensions/core.d.ts"
+      ],
+      "extensions/prisma": [
+        "dist/commonjs/extensions/prisma.d.ts"
+      ],
+      "extensions/audioWaveform": [
+        "dist/commonjs/extensions/audioWaveform.d.ts"
+      ],
+      "extensions/typescript": [
+        "dist/commonjs/extensions/typescript.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "clean": "rimraf dist",
     "build": "tshy && pnpm run update-version",
     "dev": "tshy --watch",
     "typecheck": "tsc --noEmit -p tsconfig.src.json",
-    "update-version": "tsx ../../scripts/updateVersion.ts"
+    "update-version": "tsx ../../scripts/updateVersion.ts",
+    "check-exports": "attw --pack ."
   },
   "dependencies": {
     "@trigger.dev/core": "workspace:3.0.0-beta.56",
@@ -51,7 +71,8 @@
     "tshy": "^3.0.2",
     "typescript": "^5.5.4",
     "tsx": "4.17.0",
-    "esbuild": "^0.23.0"
+    "esbuild": "^0.23.0",
+    "@arethetypeswrong/cli": "^0.15.4"
   },
   "engines": {
     "node": ">=18.20.0"