Skip to content

v3: new build system fixes #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 5, 2024
Merged

v3: new build system fixes #1278

merged 25 commits into from
Sep 5, 2024

Conversation

ericallam
Copy link
Member

@ericallam ericallam commented Sep 2, 2024

  • Fixes "X [ERROR] Could not resolve" errors when loading internal entry points for windows users
  • Fixes bundling not working when passing in the --config option
  • Add support for custom conditions (for bundling and running), to support being able to import ai/rsc with the “react-server” condition.
  • Fixed an issue where symlinking unresolvable externals after rebuilding caused the build to hang
  • Fixed an issue with external not working with subpath exports (e.g. “ai” would not match “ai/rsc”)
  • Protect better against build extensions breaking builds
  • Fixes process env vars not being correctly passed to the background worker child processes in dev (leading to missing PATH variables, etc.)

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 41e3edb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 2, 2024

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1278
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1278
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1278
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1278

commit: 41e3edb

Add support for custom conditions (for bundling and running), to support being able to import `ai/rsc` with the “react-server” condition.

- Fixed an issue where symlinking unresolvable externals after rebuilding caused the build to hang
- Fixed an issue with external not working with subpath exports (e.g. “ai” would not match “ai/rsc”)
- Protect better against build extensions breaking builds
@ericallam ericallam force-pushed the v3/new-build-system-fixes branch from cb57baa to 41e3edb Compare September 5, 2024 11:47
@ericallam ericallam merged commit f040417 into main Sep 5, 2024
10 checks passed
@ericallam ericallam deleted the v3/new-build-system-fixes branch September 5, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant