Fix for missing logs when triggering without a `trigger-version` #1331

matt-aitken · 2024-09-19T16:16:21Z

When trigger a run (or batch) without trigger-version (i.e. using HTTP POST directly) we wouldn't show any logs for a run.

Summary by CodeRabbit

Bug Fixes
- Improved handling of trace context for requests, enhancing traceability in service calls.
- Streamlined logic for determining trace context in task triggering.
Style
- Minor cosmetic adjustment in the NoLogsView component for cleaner formatting.

changeset-bot · 2024-09-19T16:16:26Z

⚠️ No Changeset found

Latest commit: 8775518

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2024-09-19T16:16:31Z

Warning

Rate limit exceeded

@ericallam has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between f52c177 and 8775518.

Walkthrough

The changes involve minor formatting adjustments and enhancements to trace context handling in the application. A space was removed in the NoLogsView component, while the api.v1.tasks.$taskId.batch.ts and api.v1.tasks.$taskId.trigger.ts files underwent modifications to improve the logic for constructing the traceContext. These updates include the addition of a new header for worker requests and the simplification of conditional checks related to trace context assignment.

Changes

Files	Change Summary
`apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam/route.tsx`	Removed a space in the JSX markup of the `NoLogsView` component; no functional changes.
`apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts`, `apps/webapp/app/routes/api.v1.tasks.$taskId.trigger.ts`	Enhanced trace context handling by adding a new header for worker requests and simplifying conditional logic for `traceContext`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Worker
    participant API
    participant Service

    Client->>API: Send request with traceparent
    API->>Service: Call service with traceContext
    Service-->>API: Return response

    Worker->>API: Send request with x-trigger-worker header
    API->>Service: Call service with traceContext
    Service-->>API: Return response

Poem

In the code where rabbits hop,
A space was lost, but never stop!
With headers new, the traces flow,
Through worker paths, they swiftly go.
Hooray for tweaks, both small and bright,
In the world of code, all feels just right! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts (1)

42-42: Approve the addition of the "x-trigger-worker" header.

The addition of the "x-trigger-worker" header allows for more flexible handling of trace context based on the request origin.

Consider adding validation or type-checking for the isFromWorker value to ensure it is a boolean and to prevent unexpected behavior if an invalid value is passed.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1679a18 and f52c177.

Files selected for processing (3)

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam/route.tsx (0 hunks)
apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts (2 hunks)
apps/webapp/app/routes/api.v1.tasks.$taskId.trigger.ts (1 hunks)

Files not reviewed due to no reviewable changes (1)

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam/route.tsx

Additional comments not posted (2)

apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts (1)

90-93: Approve the updated logic for constructing the traceContext object.

The updated logic ensures that if the request is from a worker, the trace context is still passed appropriately, enhancing the robustness of traceability in the service call. The use of the nullish coalescing operator and the ternary operator improves the readability and conciseness of the code.

apps/webapp/app/routes/api.v1.tasks.$taskId.trigger.ts (1)

82-85: LGTM! The changes simplify the logic for setting traceContext.

The removal of the triggerVersion check and the use of the nullish coalescing operator (??) streamline the control flow and reduce the complexity of the conditional logic. This ensures that traceContext is set appropriately based on the presence of traceparent or isFromWorker, regardless of the triggerVersion value.

The changes improve the readability and maintainability of the code while preserving the intended functionality.

pkg-pr-new · 2024-09-19T16:25:29Z

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1331

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1331

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1331

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1331

commit: 8775518

… to be populated

coderabbitai bot reviewed Sep 19, 2024

View reviewed changes

ericallam approved these changes Sep 20, 2024

View reviewed changes

matt-aitken added 2 commits September 20, 2024 11:13

No longer require “trigger-version” to be passed for the traceContext…

5d7232b

… to be populated

Remove empty string

8775518

ericallam force-pushed the missing-log-fixes branch from f52c177 to 8775518 Compare September 20, 2024 10:13

ericallam merged commit b999c86 into main Sep 20, 2024
7 checks passed

ericallam deleted the missing-log-fixes branch September 20, 2024 10:14

coderabbitai bot mentioned this pull request Sep 23, 2024

GitHub workflow improvements #1306

Merged

coderabbitai bot mentioned this pull request Apr 2, 2025

Run page improvements #1874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix for missing logs when triggering without a `trigger-version` #1331

Fix for missing logs when triggering without a `trigger-version` #1331

Uh oh!

matt-aitken commented Sep 19, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

pkg-pr-new bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix for missing logs when triggering without a trigger-version #1331

Fix for missing logs when triggering without a trigger-version #1331

Uh oh!

Conversation

matt-aitken commented Sep 19, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix for missing logs when triggering without a `trigger-version` #1331

Fix for missing logs when triggering without a `trigger-version` #1331

matt-aitken commented Sep 19, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Sep 19, 2024 •

edited

Loading