Run page improvements #1874
Run page improvements #1874
Conversation
|
WalkthroughThis pull request updates three files. In the hooks module, a new type ( Changes
Sequence Diagram(s)sequenceDiagram
participant TraceView
participant ReplaceSearchHook
participant setSearchParams
TraceView->>ReplaceSearchHook: replaceSearchParam("span", selectedSpan, { replace: true })
ReplaceSearchHook->>setSearchParams: setSearchParams(newParams, { replace: true })
sequenceDiagram
participant RunPresenter
participant EventData
RunPresenter->>EventData: Process event n
alt n.data.isDebug is false
RunPresenter->>RunPresenter: totalDuration = max(current, offset + n.data.duration)
else
RunPresenter->>RunPresenter: Skip updating totalDuration
end
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/webapp/app/hooks/useReplaceSearchParams.ts (1)
23-23: Consider removing searchParams from the dependency array.The callback doesn't use the
searchParamsvalue internally, so including it in the dependency array may cause unnecessary re-renders.- [searchParams] + [setSearchParams]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/webapp/app/hooks/useReplaceSearchParams.ts(1 hunks)apps/webapp/app/presenters/v3/RunPresenter.server.ts(1 hunks)apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: typecheck / typecheck
🔇 Additional comments (5)
apps/webapp/app/hooks/useReplaceSearchParams.ts (3)
4-7: Well-structured type definition for navigation options.The
NavigateOptionstype correctly defines optional properties that match React Router's navigation options, providing type safety for the new parameter.
13-13: Function signature updated to support navigation options.The updated function signature allows clients to specify how navigation should behave when replacing search parameters.
21-21: Navigation options correctly passed to setSearchParams.This change properly forwards the navigation options to the underlying React Router function.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx (1)
309-309: Prevent span selection from adding browser history entries.This change ensures that when a user selects a span (via mouse or keyboard), it doesn't add a new entry to the browser history, improving navigation experience as specified in the PR objectives.
apps/webapp/app/presenters/v3/RunPresenter.server.ts (1)
162-165: Prevent debug logs from extending timeline duration.This change ensures that debug logs (visible only to admins) don't artificially extend the duration of the run timeline, which directly addresses the second objective of the PR. The clear comment also helps explain the purpose of this conditional check.
Two run page improvements
Summary by CodeRabbit