Queues page: fix for upgrade state, and upgrade docs link

[matt-aitken]

• Fix for the queues showing when they shouldn't have been (i.e. on v3)
• Fix for bad docs link to upgrade to v4 guide

Summary by CodeRabbit

• Refactor

  • Streamlined conditional rendering on the queues page for a consistent experience. Users will now see clear messages when there are no tasks or when an upgrade prompt is needed.

• Documentation

  • Updated the upgrade guide link to direct users to the latest instructions for progressing to the newer engine version.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6b4e33b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request simplifies the control flow in both the queue presenter and the page component. In the presenter, the conditional branch that previously returned a failure response under specific circumstances has been removed in favor of a single failure return. In the page component, the conditional rendering has been reorganized to first check if there are no queues before evaluating the engine version, and an update to a documentation link path has been applied.

Changes

File(s)	Change Summary
apps/webapp/app/presenters/.../QueueListPresenter.server.ts	Removed the conditional else block; now always returns a failure response with {success: false, code: "engine-version", totalQueues} after condition evaluation.
apps/webapp/app/routes/.../queues/route.tsx	Reorganized conditional rendering: checks totalQueues === 0 first to render QueuesHasNoTasks, then conditionally renders EngineVersionUpgradeCallout based on code value; updated the documentation link from "v4-upgrade" to "upgrade-to-v4".

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant QLP as QueueListPresenter
    C->>QLP: call(totalQueues, engineVersion)
    QLP->>QLP: Evaluate conditions
    QLP->>C: Return {success: false, code: "engine-version", totalQueues}

Loading

sequenceDiagram
    participant P as Page Component
    P->>P: Check if totalQueues equals 0
    alt totalQueues is 0
        P->>P: Render QueuesHasNoTasks component
    else totalQueues not 0
        P->>P: Check if code equals "engine-version"
        alt code equals "engine-version"
            P->>P: Render EngineVersionUpgradeCallout (with updated docs link)
        end
    end

Loading

Poem

I'm a rabbit leaping in code so bright,
Hopping past branches that hid in the night.
Conditions aligned, simplicity in view,
A failure returned when the logic is due.
Carrots and changes, in flow we delight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49c067d and 6b4e33b.

📒 Files selected for processing (2)

• apps/webapp/app/presenters/v3/QueueListPresenter.server.ts (1 hunks)
• apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.