Skip to content

Queues page: fix for upgrade state, and upgrade docs link #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Queues page: fix for upgrade state, and upgrade docs link #1862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/webapp/app/presenters/v3/QueueListPresenter.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ export class QueueListPresenter extends BasePresenter {
code: "engine-version",
totalQueues: 1,
};
} else {
return {
success: false as const,
code: "engine-version",
totalQueues,
};
}
}

return {
success: false as const,
code: "engine-version",
totalQueues,
};
}

return {
Expand Down
20 changes: 11 additions & 9 deletions .../routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,14 +439,12 @@ export default function Page() {
</div>
) : (
<div className="grid place-items-center py-6 text-text-dimmed">
{code === "engine-version" ? (
totalQueues === 0 ? (
<div className="pt-12">
<QueuesHasNoTasks />
</div>
) : (
<EngineVersionUpgradeCallout />
)
{totalQueues === 0 ? (
<div className="pt-12">
<QueuesHasNoTasks />
</div>
) : code === "engine-version" ? (
<EngineVersionUpgradeCallout />
) : (
<Callout variant="error">Something went wrong</Callout>
)}
Expand Down Expand Up @@ -628,7 +626,11 @@ function EngineVersionUpgradeCallout() {
<div className="mt-4 flex max-w-lg flex-col gap-4 rounded-sm border border-grid-bright bg-background-bright px-4">
<div className="flex items-center justify-between gap-2 border-b border-grid-dimmed py-4">
<h4 className="text-base text-text-bright">New queues table</h4>
<LinkButton LeadingIcon={BookOpenIcon} to={docsPath("v4-upgrade")} variant={"docs/small"}>
<LinkButton
LeadingIcon={BookOpenIcon}
to={docsPath("upgrade-to-v4")}
variant={"docs/small"}
>
Upgrade guide
</LinkButton>
</div>
Expand Down