Update Infinite Re-computation Issue in useFetch Composable Example #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying data.value and error.value within watchEffect has the potential to trigger infinite re-renders.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spaden
changed the title
spaden
changed the title
NataliaTepluhina
approved these changes
Sep 20, 2023
|
@NataliaTepluhina please, correct me if I'm wrong, but modifying a |
Skatox
added a commit
to Skatox/vuejs-spanish-docs
that referenced
this pull request
Mar 30, 2024
Modifying data.value and error.value within watchEffect has the potential to trigger infinite re-renders.
Skatox
added a commit
to Skatox/vuejs-spanish-docs
that referenced
this pull request
Apr 8, 2024
Modifying data.value and error.value within watchEffect has the potential to trigger infinite re-renders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
https://vuejs.org/guide/reusability/composables.html#accepting-reactive-state
The watchEffect should not modify data.value and error.value used in this example to avoid infinite re-computations.