Skip to content

Update Infinite Re-computation Issue in useFetch Composable Example #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update Infinite Re-computation Issue in useFetch Composable Example #2473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/guide/reusability/composables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,16 @@ export function useFetch(url) {
const data = ref(null)
const error = ref(null)

watchEffect(() => {
// reset state before fetching..
data.value = null
error.value = null
// toValue() unwraps potential refs or getters
fetch(toValue(url))
const fetchData = (dt) => {
fetch(toValue(url))
.then((res) => res.json())
.then((json) => (data.value = json))
.catch((err) => (error.value = err))
}

watchEffect(() => {
// reset state before fetching..
fetchData(url)
})

return { data, error }
Expand Down