refactor: improve edit filename ui #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pdanpdan
commented
Dec 12, 2023
pdanpdan
commented
- remove the ugly black on white input not respecting the theme
- position the editing on top of the original title
- autogrow the size of the tab while editing
- remove the ugly black on white input not respecting the theme - position the editing on top of the original title - autogrow the size of the tab while editing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sxzz
reviewed
Dec 13, 2023
…in the editor below When adding new files the old selected file is still displayed in the editor, so the active marker should stay only on that tab. ref: vuejs#178 (review)
|
Another bug: background is dislocation when the input is empty. |
pdanpdan
added a commit
to pdanpdan/vue-repl
that referenced
this pull request
Dec 13, 2023
…in the editor below When adding new files the old selected file is still displayed in the editor, so the active marker should stay only on that tab. ref: vuejs#178 (review)
|
Good points, fixed. |
pdanpdan
added a commit
to pdanpdan/vue-repl
that referenced
this pull request
Dec 13, 2023
sxzz
approved these changes
Dec 13, 2023
sxzz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.