Skip to content

refactor: improve edit filename ui #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2023
Merged

refactor: improve edit filename ui #178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f31bce4
feat(FileSelector): improve aspect of file tabs when editing file name
pdanpdan Dec 12, 2023
9f9e756
fix(FileSelector): only mark edited tab as active if it is displayed …
pdanpdan Dec 13, 2023
1815e10
fix(FileSelector): keep edited tab bg height when file name is empty
pdanpdan Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions src/editor/FileSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ function horizontalScroll(e: WheelEvent) {
<div
v-if="(pending === true && i === files.length - 1) || pending === file"
class="file pending"
:class="{ active: pending === file }"
>
<span class="file pending">{{ pendingFilename }}</span>
<input
v-model="pendingFilename"
spellcheck="false"
Expand Down Expand Up @@ -196,6 +198,7 @@ function horizontalScroll(e: WheelEvent) {
}

.file {
position: relative;
display: inline-block;
font-size: 13px;
font-family: var(--font-code);
Expand All @@ -213,18 +216,25 @@ function horizontalScroll(e: WheelEvent) {
padding: 8px 10px 6px;
line-height: 20px;
}
.file.pending span {
min-width: 50px;
min-height: 34px;
padding-right: 32px;
background-color: rgba(200, 200, 200, 0.2);
color: transparent;
}
.file.pending input {
width: 90px;
height: 30px;
line-height: 30px;
outline: none;
border: 1px solid var(--border);
border-radius: 4px;
padding: 0 0 0 10px;
margin-top: 2px;
margin-left: 6px;
position: absolute;
inset: 8px 7px auto;
font-size: 13px;
font-family: var(--font-code);
font-size: 12px;
line-height: 20px;
outline: none;
border: none;
padding: 0 3px;
min-width: 1px;
color: inherit;
background-color: transparent;
}
.file .remove {
display: inline-block;
Expand Down