Gh279 streaming example #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cognizing ogg vorbis.
…-cloud/unity-sdk into gh279-streaming-example
Fix detect silence to work with smaller audio chunks
|
@mediumTaj Just noticed that the maxLevel logic was reverted again. Both streaming samples need to be updated to use |
|
@mediumTaj Also, we lost the change to |
|
good catches, thanks! |
Update WSConnector send loop on .NET Core
|
@kimberlysiva I'm planning to merge this PR in today - if you have some time can you review it and let me know if we are missing anything? |
|
@mediumTaj I've been testing it today and things look good (also on Hololens, very responsive!) I think we may want to rename |
Changed OnListen to return a bool, true if audio was sent/enqueued
…r-cloud/unity-sdk into gh279-streaming-example
|
Awesome thanks! Chunked rename is done and pushed. After we pass CI, I'll merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Speech to Text streaming example